linux-kernel - Re: [PATCH 4/8] arm64: dts: hisilicon: Use generic "ngpios" rather than "snps,nr-gpios"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5FBDC161.8020700@hisilicon.com>
Date:   Wed, 25 Nov 2020 10:28:49 +0800
From:   Wei Xu <xuwei5@...ilicon.com>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Dinh Nguyen" <dinguyen@...nel.org>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Saravana Kannan <saravanak@...gle.com>,
        "Linus Walleij" <linus.walleij@...aro.org>
Subject: Re: [PATCH 4/8] arm64: dts: hisilicon: Use generic "ngpios" rather
 than "snps,nr-gpios"

Hi Jisheng,

On 2020/11/9 17:05, Jisheng Zhang wrote:
> This is to remove similar errors as below:
> 
> OF: /.../gpio-port@0: could not find phandle
> 
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> index bc49955360db..fbe83eb9f77b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> @@ -335,7 +335,7 @@ porta: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> @@ -354,7 +354,7 @@ portb: gpio-controller@0 {
>  				compatible = "snps,dw-apb-gpio-port";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>  				reg = <0>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> 

Thanks!
Applied to the hisilicon arm64 dt tree.

Best Regards,
Wei