linux-kernel - Re: [PATCH v1 1/4] dt-bindings: ata: tegra: Convert binding documentation to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_Jsq+g_sXp4t9dPq5LOrhKrsXyu+3-ZCRFqw-AZJs_S=6M=A@mail.gmail.com>
Date:   Fri, 13 Nov 2020 07:59:30 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@...r.kernel.org>, devicetree@...r.kernel.org,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: ata: tegra: Convert binding
 documentation to YAML

On Thu, Nov 12, 2020 at 9:54 PM Sowjanya Komatineni
<skomatineni@...dia.com> wrote:
>
> Hi Rob,
>
> Updated yamllint and dt-schema as well.
>
> When I do make dt_binding_check, I see it failed as
> processed-schema-examples.json is not generated.
> Any idea of what I may be missing?
>
> Also it did not go thru bindings/ata path. Tried with DT_SCHEMA_FILES to
> tegra-ahci.yaml as well and I see same.
> make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
>
> LINT    Documentation/devicetree/bindings
> ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:20:9: [warning]
> wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:30:9: [warning]
> wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:33:9: [warning]
> wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml:37:2:
> [error] syntax error: expected <block end>, but found '<scalar>' (syntax)

I believe this error only occurred on linux-next. linux-next is not a
base you should develop on (usually). rc2 is good. Unfortunately
someone broke rc3.

> ./Documentation/devicetree/bindings/soc/aspeed/xdma.yaml:10:2: [warning]
> wrong indentation: expected 2 but found 1 (indentation)
> ./Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml:10:4:
> [warning] wrong indentation: expected 2 but found 3 (indentation)
> ./Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml:18:7:
> [warning] wrong indentation: expected 4 but found 6 (indentation)
> ./Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml:10:4:
> [warning] wrong indentation: expected 2 but found 3 (indentation)
> ./Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml:15:7:
> [warning] wrong indentation: expected 4 but found 6 (indentation)
> ./Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml:25:10:
> [warning] wrong indentation: expected 10 but found 9 (indentation)
> ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:52:9:
> [warning] wrong indentation: expected 6 but found 8 (indentation)
> ./Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml:32:13:
> [warning] wrong indentation: expected 14 but found 12 (indentation)
> ./Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml:35:9:
> [warning] wrong indentation: expected 10 but found 8 (indentation)
> Documentation/devicetree/bindings/Makefile:59: recipe for target
> 'Documentation/devicetree/bindings/processed-schema-examples.json' failed
> make[1]: ***
> [Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
> Makefile:1362: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2

Use 'make -k' if there are unrelated errors.

>
> When I do dtbs_check, I see
> Documentation/devicetree/bindings/processed-schema.json generated and
> also it passes for tegra-ahci.yaml

Then it should be good.

Rob

>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
>
> Regards,
>
> Sowjanya
>
>
> On 11/6/20 9:18 AM, Sowjanya Komatineni wrote:
> >
> > On 11/6/20 8:41 AM, Sowjanya Komatineni wrote:
> >>
> >> On 11/6/20 8:11 AM, Rob Herring wrote:
> >>> On Thu, 05 Nov 2020 18:16:05 -0800, Sowjanya Komatineni wrote:
> >>>> This patch converts text based dt-binding document to YAML based
> >>>> dt-binding document.
> >>>>
> >>>> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>
> >>>> ---
> >>>>   .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 152
> >>>> +++++++++++++++++++++
> >>>>   .../bindings/ata/nvidia,tegra124-ahci.txt          |  44 ------
> >>>>   2 files changed, 152 insertions(+), 44 deletions(-)
> >>>>   create mode 100644
> >>>> Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> >>>>   delete mode 100644
> >>>> Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
> >>>>
> >>>
> >>> My bot found errors running 'make dt_binding_check' on your patch:
> >>>
> >>> yamllint warnings/errors:
> >>>
> >>> dtschema/dtc warnings/errors:
> >>> Error:
> >>> Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dts:27.31-32
> >>> syntax error
> >>> FATAL ERROR: Unable to parse input tree
> >>> make[1]: *** [scripts/Makefile.lib:342:
> >>> Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dt.yaml]
> >>> Error 1
> >>> make[1]: *** Waiting for unfinished jobs....
> >>> make: *** [Makefile:1364: dt_binding_check] Error 2
> >>>
> >>>
> >>> See https://patchwork.ozlabs.org/patch/1395390
> >>>
> >>> The base for the patch is generally the last rc1. Any dependencies
> >>> should be noted.
> >>>
> >>> If you already ran 'make dt_binding_check' and didn't see the above
> >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> >>> date:
> >>>
> >>> pip3 install dtschema --upgrade
> >>>
> >>> Please check and re-submit.
> >> Thanks Rob. Will re-try after installing up-to-date.
> >
> > Somehow running 'make dt_binding_check' gives below error.
> >
> > I have yamllint newest version (1.2.1-1). Any specific version of
> > yamllint is needed?
> >
> >  LINT    Documentation/devicetree/bindings
> > invalid config: unknown option "max-spaces-inside-empty" for rule
> > "braces"
> > xargs: /usr/bin/yamllint: exited with status 255; aborting
> > Documentation/devicetree/bindings/Makefile:59: recipe for target
> > 'Documentation/devicetree/bindings/processed-schema-examples.json' failed
> > make[1]: ***
> > [Documentation/devicetree/bindings/processed-schema-examples.json]
> > Error 124
> > Makefile:1362: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> >