linux-kernel - Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201113013306.GA13261@chenyu-office.sh.intel.com>
Date:   Fri, 13 Nov 2020 09:33:06 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     "Raj, Ashok" <ashok.raj@...el.com>
Cc:     Borislav Petkov <bp@...en8.de>, Len Brown <len.brown@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Tony Luck <tony.luck@...el.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...el.com>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and
 processor flag before saving microcode

Hi Ashok,
On Thu, Nov 12, 2020 at 01:54:42PM -0800, Raj, Ashok wrote:
> Hi ChenYu
> 
> I think you can drop the RFC tag.
> 
> I suppose you can add Cc stable as well. Boris should return next week to
> take a look.
>
Ok, I'll do and send another version out.
> 
> On Tue, Nov 10, 2020 at 09:52:47PM +0800, Chen Yu wrote:
> > Currently scan_microcode() leverages microcode_matches() to check if the
> > microcode matches the CPU by comparing the family and model. However before
> > saving the microcode in scan_microcode(), the processor stepping and flag
> > of the microcode signature should also be considered in order to avoid
> > incompatible update and caused the failure of microcode update.
> > 
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208535
> > Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
> > Suggested-by: "Raj, Ashok" <ashok.raj@...el.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Len Brown <len.brown@...el.com>
> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> > Cc: "Raj, Ashok" <ashok.raj@...el.com>
> > Cc: Tony Luck <tony.luck@...el.com>
> > Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> > --
> 
> Reviewed-by: Ashok Raj <ashok.raj@...el.com>
> 
Thanks!

Best,
Chenyu
> Cheers,
> Ashok