linux-kernel - Re: [PATCH] mailbox: arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY1LH_3TdD4uLc297VOiuEkarWh5p4ZF2qDmbo1B0uH+dw@mail.gmail.com>
Date:   Thu, 12 Nov 2020 19:34:49 -0600
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Tushar Khandelwal <Tushar.Khandelwal@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Sudeep Holla <Sudeep.Holla@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Morten Borup Petersen <morten_bp@...e.dk>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Usama Arif <usama.arif@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mailbox: arm_mhuv2: Add driver

On Wed, Nov 11, 2020 at 12:02 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 27-10-20, 17:23, Viresh Kumar wrote:
> > This adds driver for the ARM MHUv2 (Message Handling Unit) mailbox
> > controller.
> >
> > This is based on the accepted DT bindings of the controller and supports
> > combination of all transport protocols, i.e. single-word, multi-word and
> > doorbell.
> >
> > Transmitting and receiving data through the mailbox framework in
> > multi-word mode is done through struct arm_mhuv2_mbox_msg. Rest of the
> > implementation details can be seen in the bindings document or in the
> > driver itself.
> >
> > Based on the initial work done by Morten Borup Petersen from ARM.
> >
> > Co-developed-by: Tushar Khandelwal <tushar.khandelwal@....com>
> > Signed-off-by: Tushar Khandelwal <tushar.khandelwal@....com>
> > Tested-by: Usama Arif <usama.arif@....com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > ---
> > Bindings are already reviewed by Rob and are present here:
> >
> > http://lore.kernel.org/lkml/61ca14fc441f92c1e7994e5bebae5c49811a3050.1602563406.git.viresh.kumar@linaro.org
>
> Jassi, Any inputs on this ?
>
Can we make 'single-word' as a special case of 'multi-word',  i.e,
effect single-word by specifying 1 sized multi-word.
And the names of structs and members could be lower case? It seems
very firmware style, or is it just me?

cheers.