linux-kernel - Re: [PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5831dbd-04be-cd4d-e18f-2c2388c69aa7@iogearbox.net>
Date:   Fri, 13 Nov 2020 16:32:10 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Wang Hai <wanghai38@...wei.com>, andrii.nakryiko@...il.com,
        mrostecki@...nsuse.org, john.fastabend@...il.com
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 bpf] tools: bpftool: Add missing close before bpftool
 net attach exit

On 11/13/20 12:51 PM, Wang Hai wrote:
> progfd is created by prog_parse_fd(), before 'bpftool net attach' exit,
> it should be closed.
> 
> Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface")
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

Applied & improved commit msg a bit, thanks!