linux-kernel - Re: [PATCH 3/2] checkpatch: document the function renaming and deprecation around devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe5ad7c72eadac32eda6a41b61feaa42c04392b0.camel@perches.com>
Date:   Fri, 13 Nov 2020 08:36:44 -0800
From:   Joe Perches <joe@...ches.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH 3/2] checkpatch: document the function renaming and
 deprecation around devm_ioremap_resource

On Fri, 2020-11-13 at 10:11 +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
> 
> this can also be squashed into the respective patches instead.
> 
> Best regards
> Uwe
> 
>  scripts/checkpatch.pl | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -615,6 +615,11 @@ our %deprecated_apis = (
>  	"rcu_barrier_sched"			=> "rcu_barrier",
>  	"get_state_synchronize_sched"		=> "get_state_synchronize_rcu",
>  	"cond_synchronize_sched"		=> "cond_synchronize_rcu",
> +	"devm_platform_get_and_ioremap_resource" => "devm_platform_get_request_and_ioremap_resource",

Do we really need 46 character length function names?

> +	"devm_platform_ioremap_resource"	=> "devm_platform_request_ioremap_resource",
> +	"devm_platform_ioremap_resource_wc"	=> "devm_platform_request_ioremap_resource_wc",
> +	"devm_ioremap_resource"			=> "devm_request_ioremap_resource",
> +	"devm_ioremap_resource_wc"		=> "devm_request_ioremap_resource_wc",
>  );
>  
> 
>  #Create a search pattern for all these strings to speed up a loop below

And do please send your proposed patches to the appropriate maintainers.