lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e552f6a9-8b82-f446-d67d-2f666870c766@linux.ibm.com>
Date:   Sat, 14 Nov 2020 10:42:18 +0100
From:   Frederic Barrat <fbarrat@...ux.ibm.com>
To:     Alexey Kardashevskiy <aik@...abs.ru>, Marc Zyngier <maz@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Cédric Le Goater <clg@...d.org>,
        Michael Ellerman <mpe@...erman.id.au>, Qian Cai <cai@....pw>,
        Rob Herring <robh@...nel.org>,
        Michal Suchánek <msuchanek@...e.de>
Subject: Re: [PATCH kernel v3] genirq/irqdomain: Add reference counting to
 IRQs

On 14/11/2020 04:37, Alexey Kardashevskiy wrote:

>> I'll try to go through this patch over the week-end (or more probably
>> early next week), and try to understand where our understandings
>> differ.
> 
> Great, thanks! Fred spotted a problem with irq_free_descs() not doing 
> kobject_put() anymore and this is a problem for sa1111.c and the likes 
> and I will go though these places anyway.

So there are callers out there which don't care about mapping the 
interrupt. Wouldn't it be easier to leave alone the kobject from the irq 
descriptor (my understanding is that it's there to handle the sysfs 
representation) and add a simple kref counter, just to handle the 
mapping part?

   Fred


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ