linux-kernel - Re: [PATCH v2 1/3] rtc: rx6110: add i2c support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116144343.GA1689012@smile.fi.intel.com>
Date:   Mon, 16 Nov 2020 16:43:43 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Claudius Heine <ch@...x.de>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Henning Schild <henning.schild@...mens.com>,
        Johannes Hahn <johannes-hahn@...mens.com>
Subject: Re: [PATCH v2 1/3] rtc: rx6110: add i2c support

On Thu, Nov 12, 2020 at 02:07:32PM +0100, Claudius Heine wrote:
> The RX6110 also supports I2C, so this patch adds support for it to the
> driver.
> 
> This also renames the SPI specific functions and variables to include
> `_spi_` in their names.

As practice shows this is not the best approach. Can you ratqer split it to
three modules: core, spi, i2c like it's done in many other cases (esp. IIO)?

In Kconfig you just leave same option with two additional ones like

config ..._SPI
	tristate
	default SPI_MASTER
	depends on SPI_MASTER

config ..._I2C
	tristate
	default I2C
	depends on I2C

-- 
With Best Regards,
Andy Shevchenko