linux-kernel - Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116144631.GB1689012@smile.fi.intel.com>
Date:   Mon, 16 Nov 2020 16:46:31 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Claudius Heine <ch@...x.de>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Henning Schild <henning.schild@...mens.com>,
        Johannes Hahn <johannes-hahn@...mens.com>
Subject: Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

On Thu, Nov 12, 2020 at 02:07:33PM +0100, Claudius Heine wrote:
> From: Johannes Hahn <johannes-hahn@...mens.com>
> 
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

Before adding new ACPI ID, can you provide an evidence (either from vendor of
the component, or a real snapshot of DSDT from device on market) that this is
real ID?

Before that happens, NAK.

P.S. Seems to me that this is kinda cargo cult patch because proposed ID is
against ACPI and PNP registry and ACPI specification.

-- 
With Best Regards,
Andy Shevchenko