linux-kernel - Re: [PATCH 4/5] dt-bindings: add vendor bindings for OnePlus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116145352.GB1625774@bogus>
Date:   Mon, 16 Nov 2020 08:53:52 -0600
From:   Rob Herring <robh@...nel.org>
To:     Caleb Connolly <caleb@...nolly.tech>
Cc:     linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: add vendor bindings for OnePlus

On Thu, Nov 12, 2020 at 04:21:54PM +0000, Caleb Connolly wrote:
> Used by the OnePlus 6/T device trees
> 
> Signed-off-by: Caleb Connolly <caleb@...nolly.tech>
> ---
>  .../bindings/arm/oneplus/oneplus-boards.yaml  | 25 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
>  2 files changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml
> new file mode 100644
> index 000000000000..a4d9bbd5681f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml
> @@ -0,0 +1,25 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/oneplus/oneplus-boards.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OnePlus based boards
> +
> +maintainers:
> +  - Caleb Connolly <caleb@...nolly.tech>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: SDM845 based boards

There should be a sdm845 fallback compatible. Also, board level 
compatibles are documented in a per SoC family schema (qcom.yaml) which 
should already define the fallback.

> +        items:
> +          - enum:
> +              - oneplus,enchilada               # OnePlus 6
> +              - oneplus,fajita                  # OnePlus 6T
> +          - const: oneplus,oneplus6             # OnePlus 6 and derivatives

With a SoC fallback, having this as a 3rd compatible probably isn't too 
useful. 3 levels of compatible is mainly done when there's a SoM plus 
baseboard.

> +
> +required:
> +  - compatible
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 2735be1a8470..372c1136081e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -768,6 +768,8 @@ patternProperties:
>      description: OLIMEX Ltd.
>    "^olpc,.*":
>      description: One Laptop Per Child
> +  "^oneplus,.*":
> +    description: One Plus Technology (Shenzhen) Co., Ltd.
>    "^onion,.*":
>      description: Onion Corporation
>    "^onnn,.*":
> -- 
> 2.29.2
> 
>