linux-kernel - Re: [PATCH] perf vendor events: Update Skylake client events to v50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201116145355.GU894261@tassilo.jf.intel.com>
Date:   Mon, 16 Nov 2020 06:53:55 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     "Jin, Yao" <yao.jin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel <Linux-kernel@...r.kernel.org>,
        "Liang, Kan" <kan.liang@...el.com>, "Jin, Yao" <yao.jin@...el.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50

>    I'd prefer if we could make a copy of these scripts into the kernel tree
>    along with the data files from:
>    https://download.01.org/perfmon/

FWIW I originally tried this to include the raw JSON files, but Ingo objected
and wanted the files to be split up[1] and avoiding redundant headers. 
That's why we ended up with the "compiled" format.

[1] https://lkml.org/lkml/2015/5/28/336

>    Having a generated file that can't be edited, reviewed, .. I also worry
>    that if/when we change the json format then event-converter-for-linux-perf
>    will need to support a multitude of perf versions.

You mean for backports? The assumption was that perf backports would backport
any perf changes for new formats too.

In general I generally discourage any perf tools backport, people should just use
a new version of the perf tool on old kernels.

In principle the scripts could be included, but without the raw files it would
be somewhat pointless.

-andi