| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202011162356.2dksRicD-lkp@intel.com>
Date: Mon, 16 Nov 2020 23:42:49 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Jonathan Corbet <corbet@....net>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-media@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Linux Doc Mailing List <linux-doc@...r.kernel.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 27/27] scripts: kernel-doc: validate kernel-doc markup
with the actual names
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20201116]
[cannot apply to drm-intel/for-linux-next s390/features tip/timers/core tip/irq/core tip/sched/core linus/master hnaz-linux-mm/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
base: 034307507118f7e1b18f8403c85af2216da2dc94
config: arm-randconfig-r006-20201116 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
git checkout 11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
arch/arm/common/locomo.c:369: warning: Function parameter or member 'me' not described in '__locomo_probe'
arch/arm/common/locomo.c:369: warning: Function parameter or member 'mem' not described in '__locomo_probe'
arch/arm/common/locomo.c:369: warning: Function parameter or member 'irq' not described in '__locomo_probe'
>> arch/arm/common/locomo.c:369: warning: expecting prototype for locomo_probe(). Prototype was for __locomo_probe() instead
vim +369 arch/arm/common/locomo.c
b38d950d3aedf90 John Lenz 2005-09-08 353
4ebf2d00260bac5 Pavel Machek 2006-03-15 354
^1da177e4c3f415 Linus Torvalds 2005-04-16 355 /**
^1da177e4c3f415 Linus Torvalds 2005-04-16 356 * locomo_probe - probe for a single LoCoMo chip.
^1da177e4c3f415 Linus Torvalds 2005-04-16 357 * @phys_addr: physical address of device.
^1da177e4c3f415 Linus Torvalds 2005-04-16 358 *
^1da177e4c3f415 Linus Torvalds 2005-04-16 359 * Probe for a LoCoMo chip. This must be called
^1da177e4c3f415 Linus Torvalds 2005-04-16 360 * before any other locomo-specific code.
^1da177e4c3f415 Linus Torvalds 2005-04-16 361 *
^1da177e4c3f415 Linus Torvalds 2005-04-16 362 * Returns:
^1da177e4c3f415 Linus Torvalds 2005-04-16 363 * %-ENODEV device not found.
^1da177e4c3f415 Linus Torvalds 2005-04-16 364 * %-EBUSY physical address already marked in-use.
^1da177e4c3f415 Linus Torvalds 2005-04-16 365 * %0 successful.
^1da177e4c3f415 Linus Torvalds 2005-04-16 366 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 367 static int
^1da177e4c3f415 Linus Torvalds 2005-04-16 368 __locomo_probe(struct device *me, struct resource *mem, int irq)
^1da177e4c3f415 Linus Torvalds 2005-04-16 @369 {
ac609d266e4af4e Eric Miao 2010-02-04 370 struct locomo_platform_data *pdata = me->platform_data;
^1da177e4c3f415 Linus Torvalds 2005-04-16 371 struct locomo *lchip;
^1da177e4c3f415 Linus Torvalds 2005-04-16 372 unsigned long r;
^1da177e4c3f415 Linus Torvalds 2005-04-16 373 int i, ret = -ENODEV;
^1da177e4c3f415 Linus Torvalds 2005-04-16 374
d2a02b93cf78205 Russell King 2006-03-20 375 lchip = kzalloc(sizeof(struct locomo), GFP_KERNEL);
^1da177e4c3f415 Linus Torvalds 2005-04-16 376 if (!lchip)
^1da177e4c3f415 Linus Torvalds 2005-04-16 377 return -ENOMEM;
^1da177e4c3f415 Linus Torvalds 2005-04-16 378
^1da177e4c3f415 Linus Torvalds 2005-04-16 379 spin_lock_init(&lchip->lock);
^1da177e4c3f415 Linus Torvalds 2005-04-16 380
^1da177e4c3f415 Linus Torvalds 2005-04-16 381 lchip->dev = me;
^1da177e4c3f415 Linus Torvalds 2005-04-16 382 dev_set_drvdata(lchip->dev, lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 383
^1da177e4c3f415 Linus Torvalds 2005-04-16 384 lchip->phys = mem->start;
^1da177e4c3f415 Linus Torvalds 2005-04-16 385 lchip->irq = irq;
ac609d266e4af4e Eric Miao 2010-02-04 386 lchip->irq_base = (pdata) ? pdata->irq_base : NO_IRQ;
^1da177e4c3f415 Linus Torvalds 2005-04-16 387
^1da177e4c3f415 Linus Torvalds 2005-04-16 388 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 389 * Map the whole region. This also maps the
^1da177e4c3f415 Linus Torvalds 2005-04-16 390 * registers for our children.
^1da177e4c3f415 Linus Torvalds 2005-04-16 391 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 392 lchip->base = ioremap(mem->start, PAGE_SIZE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 393 if (!lchip->base) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 394 ret = -ENOMEM;
^1da177e4c3f415 Linus Torvalds 2005-04-16 395 goto out;
^1da177e4c3f415 Linus Torvalds 2005-04-16 396 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 397
^1da177e4c3f415 Linus Torvalds 2005-04-16 398 /* locomo initialize */
^1da177e4c3f415 Linus Torvalds 2005-04-16 399 locomo_writel(0, lchip->base + LOCOMO_ICR);
^1da177e4c3f415 Linus Torvalds 2005-04-16 400 /* KEYBOARD */
^1da177e4c3f415 Linus Torvalds 2005-04-16 401 locomo_writel(0, lchip->base + LOCOMO_KEYBOARD + LOCOMO_KIC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 402
^1da177e4c3f415 Linus Torvalds 2005-04-16 403 /* GPIO */
^1da177e4c3f415 Linus Torvalds 2005-04-16 404 locomo_writel(0, lchip->base + LOCOMO_GPO);
2a52efb2cecf782 Thomas Kunze 2008-04-29 405 locomo_writel((LOCOMO_GPIO(1) | LOCOMO_GPIO(2) | LOCOMO_GPIO(13) | LOCOMO_GPIO(14))
^1da177e4c3f415 Linus Torvalds 2005-04-16 406 , lchip->base + LOCOMO_GPE);
2a52efb2cecf782 Thomas Kunze 2008-04-29 407 locomo_writel((LOCOMO_GPIO(1) | LOCOMO_GPIO(2) | LOCOMO_GPIO(13) | LOCOMO_GPIO(14))
^1da177e4c3f415 Linus Torvalds 2005-04-16 408 , lchip->base + LOCOMO_GPD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 409 locomo_writel(0, lchip->base + LOCOMO_GIE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 410
e44237818500257 Richard Purdie 2006-06-26 411 /* Frontlight */
^1da177e4c3f415 Linus Torvalds 2005-04-16 412 locomo_writel(0, lchip->base + LOCOMO_FRONTLIGHT + LOCOMO_ALS);
^1da177e4c3f415 Linus Torvalds 2005-04-16 413 locomo_writel(0, lchip->base + LOCOMO_FRONTLIGHT + LOCOMO_ALD);
4ebf2d00260bac5 Pavel Machek 2006-03-15 414
^1da177e4c3f415 Linus Torvalds 2005-04-16 415 /* Longtime timer */
^1da177e4c3f415 Linus Torvalds 2005-04-16 416 locomo_writel(0, lchip->base + LOCOMO_LTINT);
^1da177e4c3f415 Linus Torvalds 2005-04-16 417 /* SPI */
1b0d76cb9d5a655 H Hartley Sweeten 2010-03-22 418 locomo_writel(0, lchip->base + LOCOMO_SPI + LOCOMO_SPIIE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 419
^1da177e4c3f415 Linus Torvalds 2005-04-16 420 locomo_writel(6 + 8 + 320 + 30 - 10, lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 421 r = locomo_readl(lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 422 r |= 0x8000;
^1da177e4c3f415 Linus Torvalds 2005-04-16 423 locomo_writel(r, lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 424
^1da177e4c3f415 Linus Torvalds 2005-04-16 425 locomo_writel(6 + 8 + 320 + 30 - 10 - 128 + 4, lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 426 r = locomo_readl(lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 427 r |= 0x8000;
^1da177e4c3f415 Linus Torvalds 2005-04-16 428 locomo_writel(r, lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 429
^1da177e4c3f415 Linus Torvalds 2005-04-16 430 locomo_writel(128 / 8, lchip->base + LOCOMO_HSC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 431
^1da177e4c3f415 Linus Torvalds 2005-04-16 432 /* XON */
^1da177e4c3f415 Linus Torvalds 2005-04-16 433 locomo_writel(0x80, lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 434 udelay(1000);
^1da177e4c3f415 Linus Torvalds 2005-04-16 435 /* CLK9MEN */
^1da177e4c3f415 Linus Torvalds 2005-04-16 436 r = locomo_readl(lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 437 r |= 0x10;
^1da177e4c3f415 Linus Torvalds 2005-04-16 438 locomo_writel(r, lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 439 udelay(100);
^1da177e4c3f415 Linus Torvalds 2005-04-16 440
^1da177e4c3f415 Linus Torvalds 2005-04-16 441 /* init DAC */
^1da177e4c3f415 Linus Torvalds 2005-04-16 442 r = locomo_readl(lchip->base + LOCOMO_DAC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 443 r |= LOCOMO_DAC_SCLOEB | LOCOMO_DAC_SDAOEB;
^1da177e4c3f415 Linus Torvalds 2005-04-16 444 locomo_writel(r, lchip->base + LOCOMO_DAC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 445
^1da177e4c3f415 Linus Torvalds 2005-04-16 446 r = locomo_readl(lchip->base + LOCOMO_VER);
^1da177e4c3f415 Linus Torvalds 2005-04-16 447 printk(KERN_INFO "LoCoMo Chip: %lu%lu\n", (r >> 8), (r & 0xff));
^1da177e4c3f415 Linus Torvalds 2005-04-16 448
^1da177e4c3f415 Linus Torvalds 2005-04-16 449 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 450 * The interrupt controller must be initialised before any
^1da177e4c3f415 Linus Torvalds 2005-04-16 451 * other device to ensure that the interrupts are available.
^1da177e4c3f415 Linus Torvalds 2005-04-16 452 */
ac609d266e4af4e Eric Miao 2010-02-04 453 if (lchip->irq != NO_IRQ && lchip->irq_base != NO_IRQ)
^1da177e4c3f415 Linus Torvalds 2005-04-16 454 locomo_setup_irq(lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 455
^1da177e4c3f415 Linus Torvalds 2005-04-16 456 for (i = 0; i < ARRAY_SIZE(locomo_devices); i++)
^1da177e4c3f415 Linus Torvalds 2005-04-16 457 locomo_init_one_child(lchip, &locomo_devices[i]);
^1da177e4c3f415 Linus Torvalds 2005-04-16 458 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 459
^1da177e4c3f415 Linus Torvalds 2005-04-16 460 out:
^1da177e4c3f415 Linus Torvalds 2005-04-16 461 kfree(lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 462 return ret;
^1da177e4c3f415 Linus Torvalds 2005-04-16 463 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 464
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (31215 bytes)
Powered by blists - more mailing lists