linux-kernel - Re: [PATCH] mm/lru: simplify is_file_lru() and is_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201117174727.GR29991@casper.infradead.org>
Date:   Tue, 17 Nov 2020 17:47:27 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Hui Su <sh_def@....com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote:
> On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote:
> > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote:
> > > lru_list lru bit 0 can tell whether the list is
> > > avtive lru-list or not.
> > > lru_list lru bit 1 can tell whether the list is
> > > file lru-list or not.
> > > 
> > > And fix some define type in shrink_active_list()
> > > and get_scan_count().
> > > 
> > > v1->v2:
> > > correct the commit message, and fix the define type.
> > 
> > No, still incorrect.
> 
> I am a little confused, can you tell in detail?

Have you booted a kernel with this change?  Have you run any kind of
tests on it?