linux-kernel - Re: [PATCH v1] Bluetooth: btqca: Add support to read FW build version for WCN3991 BTSoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Nov 2020 05:08:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>,
        marcel@...tmann.org, johan.hedberg@...il.com
Cc:     kbuild-all@...ts.01.org, mka@...omium.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        hemantg@...eaurora.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org, rjliao@...eaurora.org,
        hbandi@...eaurora.org
Subject: Re: [PATCH v1] Bluetooth: btqca: Add support to read FW build
 version for WCN3991 BTSoC

Hi Venkata,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linux/master linus/master v5.10-rc4 next-20201117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Venkata-Lakshmi-Narayana-Gubba/Bluetooth-btqca-Add-support-to-read-FW-build-version-for-WCN3991-BTSoC/20201118-013220
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/773b13ede05cd62b2e429541685f7be9a9ec1e7b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Venkata-Lakshmi-Narayana-Gubba/Bluetooth-btqca-Add-support-to-read-FW-build-version-for-WCN3991-BTSoC/20201118-013220
        git checkout 773b13ede05cd62b2e429541685f7be9a9ec1e7b
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/bluetooth/btqca.c:104:5: warning: no previous prototype for 'qca_read_fw_build_info' [-Wmissing-prototypes]
     104 | int qca_read_fw_build_info(struct hci_dev *hdev)
         |     ^~~~~~~~~~~~~~~~~~~~~~

vim +/qca_read_fw_build_info +104 drivers/bluetooth/btqca.c

   103	
 > 104	int qca_read_fw_build_info(struct hci_dev *hdev)
   105	{
   106		struct sk_buff *skb;
   107		struct edl_event_hdr *edl;
   108		char cmd;
   109		int err = 0;
   110		char build_label[QCA_FW_BUILD_VER_LEN];
   111		int build_lbl_len;
   112	
   113		bt_dev_dbg(hdev, "QCA read fw build info");
   114	
   115		cmd = EDL_GET_BUILD_INFO_CMD;
   116		skb = __hci_cmd_sync_ev(hdev, EDL_PATCH_CMD_OPCODE, EDL_PATCH_CMD_LEN,
   117					&cmd, HCI_EV_VENDOR, HCI_INIT_TIMEOUT);
   118		if (IS_ERR(skb)) {
   119			err = PTR_ERR(skb);
   120			bt_dev_err(hdev, "Reading QCA fw build info failed (%d)",
   121				   err);
   122			return err;
   123		}
   124	
   125		edl = (struct edl_event_hdr *)(skb->data);
   126		if (!edl) {
   127			bt_dev_err(hdev, "QCA read fw build info with no header");
   128			err = -EILSEQ;
   129			goto out;
   130		}
   131	
   132		if (edl->cresp != EDL_CMD_REQ_RES_EVT ||
   133		    edl->rtype != EDL_GET_BUILD_INFO_CMD) {
   134			bt_dev_err(hdev, "QCA Wrong packet received %d %d", edl->cresp,
   135				   edl->rtype);
   136			err = -EIO;
   137			goto out;
   138		}
   139	
   140		build_lbl_len = edl->data[0];
   141		memcpy(build_label, &edl->data[1], build_lbl_len);
   142		*(build_label + build_lbl_len) = '\0';
   143	
   144		bt_dev_info(hdev, "BT SoC FW Build info: %s", build_label);
   145	
   146	out:
   147		kfree_skb(skb);
   148		if (err)
   149			bt_dev_err(hdev, "QCA read fw build info failed (%d)", err);
   150	
   151		return err;
   152	}
   153	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (75835 bytes)