[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201117213051.GA29991@casper.infradead.org>
Date: Tue, 17 Nov 2020 21:30:51 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Eduardo Habkost <ehabkost@...hat.com>
Cc: Jonathan Corbet <corbet@....net>,
Paolo Bonzini <pbonzini@...hat.com>,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/2] kernel-doc: Handle function typedefs without
asterisks
On Tue, Nov 17, 2020 at 04:24:52PM -0500, Eduardo Habkost wrote:
> On Fri, Nov 13, 2020 at 10:39:12PM +0000, Matthew Wilcox wrote:
> > Better ... can we have a test suite for the regexes and make patches to
> > them include updates to the test suite? They have clearly passed the
> > point of human understanding ;-)
>
> Would a simple black box test script like this be desirable?
I think this is fantastic! Yes please!
Can I add one more test case?
/**
* radix_tree_lookup_slot - lookup a slot in a radix tree
* @root: radix tree root
* @index: index key
*
* Returns: the slot corresponding to the position @index in the
* radix tree @root. This is useful for update-if-exists operations.
*
* This function can be called under rcu_read_lock iff the slot is not
* modified by radix_tree_replace_slot(), otherwise it must be called
* exclusive from other writers. Any dereference of the slot must be done
* using radix_tree_deref_slot().
*/
void __rcu **radix_tree_lookup_slot(const struct radix_tree_root *root,
unsigned long index)
{ }
(we used to have a problem with multiple '*' in the return type, and
we've also had problems with adornments like __rcu)
Powered by blists - more mailing lists