linux-kernel - Re: [PATCH] KVM: SVM: fix error return code in svm_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Nov 2020 08:40:06 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Chen Zhou <chenzhou10@...wei.com>, rkrcmar@...hat.com,
        tglx@...utronix.de, mingo@...hat.com
Cc:     hpa@...or.com, x86@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: SVM: fix error return code in svm_create_vcpu()

On 17/11/20 03:54, Chen Zhou wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function svm_create_vcpu(), as done elsewhere in this
> function.
> 
> Fixes: f4c847a95654 ("KVM: SVM: refactor msr permission bitmap allocation")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>   arch/x86/kvm/svm/svm.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 1e81cfebd491..79b3a564f1c9 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -1309,8 +1309,10 @@ static int svm_create_vcpu(struct kvm_vcpu *vcpu)
>   		svm->avic_is_running = true;
>   
>   	svm->msrpm = svm_vcpu_alloc_msrpm();
> -	if (!svm->msrpm)
> +	if (!svm->msrpm) {
> +		err = -ENOMEM;
>   		goto error_free_vmcb_page;
> +	}
>   
>   	svm_vcpu_init_msrpm(vcpu, svm->msrpm);
>   
> 

Queued, thanks.

Paolo