linux-kernel - Re: [PATCH] video: fbdev: atmel_lcdfb: fixe return error code in atmel_lcdfb_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <314d2531-5d9c-fa9d-82cd-cf0a35488a38@suse.de>
Date:   Tue, 17 Nov 2020 08:41:25 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     b.zolnierkie@...sung.com
Subject: Re: [PATCH] video: fbdev: atmel_lcdfb: fixe return error code in
 atmel_lcdfb_of_init()

Hi

Am 17.11.20 um 07:13 schrieb Yang Yingliang:
> If devm_kzalloc() failed after first time, atmel_lcdfb_of_init()
> cann't return -ENOMEM, fix this by putting the error code in loop.
> 
> Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/video/fbdev/atmel_lcdfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
> index 8c1d47e52b1a..355b6120dc4f 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -987,8 +987,8 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
>  	}
>  
>  	INIT_LIST_HEAD(&pdata->pwr_gpios);
> -	ret = -ENOMEM;
>  	for (i = 0; i < gpiod_count(dev, "atmel,power-control"); i++) {
> +		ret = -ENOMEM;

I think that a better fix would have been to put it into the alloc's
error branch. But anyway

  Reviewed-by: Thomas Zimmermann <tzimmremann@...e.de>

Thanks for your patch. I'll add it to drm-misc-next.

Best regards
Thomas

>  		gpiod = devm_gpiod_get_index(dev, "atmel,power-control",
>  					     i, GPIOD_ASIS);
>  		if (IS_ERR(gpiod))
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer