[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1605605352-25298-1-git-send-email-kaixuxia@tencent.com>
Date: Tue, 17 Nov 2020 17:29:12 +0800
From: xiakaixu1987@...il.com
To: mkl@...gutronix.de, manivannan.sadhasivam@...aro.org,
thomas.kopp@...rochip.com, wg@...ndegger.com, kuba@...nel.org
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Kaixu Xia <kaixuxia@...cent.com>
Subject: [PATCH] can: mcp251xfd: remove useless code in mcp251xfd_chip_softreset
From: Kaixu Xia <kaixuxia@...cent.com>
It would directly return if the variable err equals to 0 or other errors.
Only when the err equals to -ETIMEDOUT it can reach the 'if (err)'
statement, so the 'if (err)' and last 'return -ETIMEDOUT' statements are
useless. Romove them.
Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
index 9c215f7c5f81..ceae18270c01 100644
--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
@@ -644,10 +644,7 @@ static int mcp251xfd_chip_softreset(const struct mcp251xfd_priv *priv)
return 0;
}
- if (err)
- return err;
-
- return -ETIMEDOUT;
+ return err;
}
static int mcp251xfd_chip_clock_init(const struct mcp251xfd_priv *priv)
--
2.20.0
Powered by blists - more mailing lists