[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201117100528.hfdgwe5fyckweurt@hardanger.blackshift.org>
Date: Tue, 17 Nov 2020 11:05:28 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: xiakaixu1987@...il.com
Cc: manivannan.sadhasivam@...aro.org, thomas.kopp@...rochip.com,
wg@...ndegger.com, kuba@...nel.org, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] can: mcp251xfd: remove useless code in
mcp251xfd_chip_softreset
On Tue, Nov 17, 2020 at 05:29:12PM +0800, xiakaixu1987@...il.com wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
>
> It would directly return if the variable err equals to 0 or other errors.
> Only when the err equals to -ETIMEDOUT it can reach the 'if (err)'
> statement, so the 'if (err)' and last 'return -ETIMEDOUT' statements are
> useless. Romove them.
>
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
Applied to linux-can-next/testing.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists