linux-kernel - Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdunx0pjwKBXv5OEjHk_E=sAu_N4xyCBRFoU3GKK8nnnA@mail.gmail.com>
Date:   Tue, 17 Nov 2020 13:17:18 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "johannes-hahn@...mens.com" <johannes-hahn@...mens.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...el.com>,
        Claudius Heine <ch@...x.de>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "werner.zeh@...mens.com" <werner.zeh@...mens.com>,
        "henning.schild@...mens.com" <henning.schild@...mens.com>
Subject: Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

On Tue, Nov 17, 2020 at 1:10 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Nov 17, 2020 at 9:39 AM johannes-hahn@...mens.com
> <johannes-hahn@...mens.com> wrote:
> >
> > Hello Andy,
> >
> > when comparing the ACPI IDs used in rtc-ds1307.c, which is already on mainline
> >
> > https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-ds1307.c#L1141
> >
> > for example. Every ID listed there is also not formatted the ACPI ID , PNP ID way defined in the ACPI spec.
> >
> > How about that ?
>
> Bad examples should not prevent you from doing the right thing, correct?
>
> JFYI: https://lore.kernel.org/linux-rtc/20201116142859.31257-1-andriy.shevchenko@linux.intel.com/

Moreover, this seems to be the last driver which was broken by the
same guy who "invented" ACPI IDs for them. The rest had been reverted
already.

-- 
With Best Regards,
Andy Shevchenko