linux-kernel - Re: [PATCH v3] pwm: core: Use octal permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Nov 2020 20:48:17 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Soham Biswas <sohambiswas41@...il.com>, lee.jones@...aro.org,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pwm: core: Use octal permission

On Wed, Nov 18, 2020 at 06:59:36PM +0100, Thierry Reding wrote:
> On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote:
> > Permission bits are easier readable in octal than with using the
> > symbolic names.
> > 
> > Fixes the following warning generated by checkpatch:
> > 
> > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> > not preferred. Consider using octal permissions '0444'.
> > 
> > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> >                             &pwm_debugfs_fops);
> > 
> > Signed-off-by: Soham Biswas <sohambiswas41@...il.com>
> > ---
> >  drivers/pwm/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks. Though I did unwrap the checkpatch warning message as
> Uwe suggested.

Then feel free to add my

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)