[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMmt7eO217-8aVGkrMDrRiCiJiW0RTk39k1E_GAabDXmjWO+Kg@mail.gmail.com>
Date: Thu, 19 Nov 2020 00:09:06 +0530
From: Soham Biswas <sohambiswas41@...il.com>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Lee Jones <lee.jones@...aro.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-pwm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pwm: core: Use octal permission
On Wed, 18 Nov 2020 at 23:29, Thierry Reding <thierry.reding@...il.com> wrote:
>
> On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote:
> > Permission bits are easier readable in octal than with using the
> > symbolic names.
> >
> > Fixes the following warning generated by checkpatch:
> >
> > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> > not preferred. Consider using octal permissions '0444'.
> >
> > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> > &pwm_debugfs_fops);
> >
> > Signed-off-by: Soham Biswas <sohambiswas41@...il.com>
> > ---
> > drivers/pwm/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks. Though I did unwrap the checkpatch warning message as
> Uwe suggested.
>
> Thierry
Thank You!
Powered by blists - more mailing lists