linux-kernel - Re: [PATCH v3] pwm: core: Use octal permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118175936.GB3552669@ulmo>
Date:   Wed, 18 Nov 2020 18:59:36 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Soham Biswas <sohambiswas41@...il.com>
Cc:     lee.jones@...aro.org, u.kleine-koenig@...gutronix.de,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pwm: core: Use octal permission

On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote:
> Permission bits are easier readable in octal than with using the
> symbolic names.
> 
> Fixes the following warning generated by checkpatch:
> 
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> not preferred. Consider using octal permissions '0444'.
> 
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
>                             &pwm_debugfs_fops);
> 
> Signed-off-by: Soham Biswas <sohambiswas41@...il.com>
> ---
>  drivers/pwm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. Though I did unwrap the checkpatch warning message as
Uwe suggested.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)