linux-kernel - Re: [PATCH net] atl1e: fix error return code in atl1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a0300f-056d-f952-c4d6-609b488b3e9c@huawei.com>
Date:   Wed, 18 Nov 2020 11:25:25 +0800
From:   Zhang Changzhong <zhangchangzhong@...wei.com>
To:     Marion & Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <jcliburn@...il.com>, <chris.snook@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>, <mst@...hat.com>,
        <leon@...nel.org>, <hkallweit1@...il.com>, <tglx@...utronix.de>,
        <jesse.brandeburg@...el.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] atl1e: fix error return code in atl1e_probe()



On 2020/11/18 4:38, Marion & Christophe JAILLET wrote:
> 
> Le 17/11/2020 à 03:57, Zhang Changzhong a écrit :
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
> Hi, should it have any importance, the Fixes tag is wrong.
> 
> The issue was already there before 85eb5bc33717 which was just a mechanical update.
> 
> just my 2c
> 
> CJ
> 
Thanks for reminding, the correct Fixes tag should be:

Fixes: a6a5325239c2 ("atl1e: Atheros L1E Gigabit Ethernet driver"