linux-kernel - Re: [PATCH v1 1/3] dt-bindings: mmc: Add optional cqe off properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1605670015.11864.5.camel@mhfsdcap03>
Date:   Wed, 18 Nov 2020 11:26:55 +0800
From:   Wenbin Mei <wenbin.mei@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     Ulf Hansson <ulf.hansson@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <irq-linux@...e.qmqm.pl>,
        Veerabhadrarao Badiganti <vbadigan@...eaurora.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Baolin Wang <baolin.wang@...aro.org>,
        Ludovic Barre <ludovic.barre@...com>,
        Krishna Konda <kkonda@...eaurora.org>,
        Bradley Bolen <bradleybolen@...il.com>,
        "Chaotian Jing" <chaotian.jing@...iatek.com>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, <srv_heupstream@...iatek.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add optional cqe off properties

On Mon, 2020-11-16 at 13:28 -0600, Rob Herring wrote:
> On Thu, Nov 12, 2020 at 03:52:06PM +0800, Wenbin Mei wrote:
> > Add optional properties for cqe hosts which are used to set cqe off
> > during suspend flow.
> > 
> > Signed-off-by: Wenbin Mei <wenbin.mei@...iatek.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > index b96da0c7f819..457c9a84b988 100644
> > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> > @@ -164,6 +164,13 @@ properties:
> >      description:
> >        enable SDIO IRQ signalling on this interface
> >  
> > +  cqe-off-in-suspend:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    description:
> > +      After suspend, the mmc host is powered off by HW, and bring CQE register
> > +      to default state, so we add the flag to re-init CQE register after resume
> > +      back.
> 
> The driver change is before suspend, but this says on resume...
> 
> In any case, this should be implied by the SoC specific compatible.
> 
Thanks for your reply, I will drop this patchset, and resend another
patchset for this issue.
> > +
> >    full-pwr-cycle:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> > -- 
> > 2.18.0
> >