linux-kernel - Re: [PATCH] pwm: core: Use octal permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118095026.rehosqupefcebe77@pengutronix.de>
Date:   Wed, 18 Nov 2020 10:50:26 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Soham Biswas <sohambiswas41@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, thierry.reding@...il.com,
        Joe Perches <joe@...ches.com>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: core: Use octal permission

On Wed, Nov 18, 2020 at 01:41:31AM -0800, Joe Perches wrote:
> On Wed, 2020-11-18 at 10:35 +0100, Uwe Kleine-König wrote:
> 
> > Actually I'd prefer keeping the symbolic name because this is easier to
> > grep for. So to convince me a better reason than "checkpatch says so" is
> > needed.
> 
> https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/
> -------------------------------------------------------------------
> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Date: Tue, 2 Aug 2016 16:58:29 -0400
> 
> The symbolic names are good for the *other* bits (ie sticky bit, and
> the inode mode _type_ numbers etc), but for the permission bits, the
> symbolic names are just insane crap. Nobody sane should ever use them.
> Not in the kernel, not in user space.
> 
>            Linus

OK, "Linus says so" is considerably stronger than "checkpatch says so".
So if you respin the patch with a better commit log, that's fine for me.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)