[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201118104730.4270-1-sohambiswas41@gmail.com>
Date: Wed, 18 Nov 2020 16:17:30 +0530
From: Soham Biswas <sohambiswas41@...il.com>
To: thierry.reding@...il.com
Cc: lee.jones@...aro.org, u.kleine-koenig@...gutronix.de,
linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
Soham Biswas <sohambiswas41@...il.com>
Subject: [PATCH] pwm: core: Use octal permission
Fixes the following warning generated by checkpatch:
drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
not preferred. Consider using octal permissions '0444'.
+debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
&pwm_debugfs_fops);
Signed-off-by: Soham Biswas <sohambiswas41@...il.com>
---
drivers/pwm/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 1f16f5365d3c..a8eff4b3ee36 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
static int __init pwm_debugfs_init(void)
{
- debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
+ debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL,
&pwm_debugfs_fops);
return 0;
--
2.29.2
Powered by blists - more mailing lists