linux-kernel - Re: [PATCH v2] pwm: core: Use octal permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118124312.wk6cmnktxefn7k7m@pengutronix.de>
Date:   Wed, 18 Nov 2020 13:43:12 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Soham Biswas <sohambiswas41@...il.com>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm: core: Use octal permission

[added "v2" to the subject, would have been better if you had already
done that. I don't know if/how this confuses tools like b4 and patchwork]

Hello,

On Wed, Nov 18, 2020 at 04:17:30PM +0530, Soham Biswas wrote:
> Fixes the following warning generated by checkpatch:
> 
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> not preferred. Consider using octal permissions '0444'.
> 
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> 			    &pwm_debugfs_fops);

something like: "Permission bits are easier readable in octal than with
using the symbolic names." in the commit log would be good for those of
us who missed why this was added to checkpatch.

Best regards
Uwe
 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)