linux-kernel - Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e9cf9b4-18db-be29-1133-c15e2e55cbd6@redhat.com>
Date:   Wed, 18 Nov 2020 07:47:34 -0800
From:   Tom Rix <trix@...hat.com>
To:     Russ Weight <russell.h.weight@...el.com>, mdf@...nel.org,
        lee.jones@...aro.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     lgoncalv@...hat.com, yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...el.com
Subject: Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update
 driver


>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	ret = regmap_bulk_read(sec->m10bmc->regmap, reh_addr,
>>> +			       hash, sha_num_bytes / stride);
>> Assumes !(sha_num_bytes % stride)
> Yes - good point. I'll add WARN_ON() here and for the CSK cancellation vectors.
> In these cases, the size values are fixed, so a WARN_ON should be sufficient.

Yes, thanks.

Tom

> Thanks,
> - Russ
>