linux-kernel - Re: [PATCH v5 5/6] fpga: m10bmc-sec: add max10 secure update functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fe70aff-b0ac-22dd-5f90-53924b20d8ef@redhat.com>
Date:   Wed, 18 Nov 2020 07:57:05 -0800
From:   Tom Rix <trix@...hat.com>
To:     Russ Weight <russell.h.weight@...el.com>, mdf@...nel.org,
        lee.jones@...aro.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     lgoncalv@...hat.com, yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...el.com
Subject: Re: [PATCH v5 5/6] fpga: m10bmc-sec: add max10 secure update
 functions


On 11/17/20 4:10 PM, Russ Weight wrote:
>
> On 11/15/20 6:17 AM, Tom Rix wrote:
>> On 11/13/20 4:55 PM, Russ Weight wrote:
>>> Extend the MAX10 BMC Secure Update driver to include
>>>
>>> +
>>> +	status = rsu_stat(doorbell);
>>> +	if (status == RSU_STAT_WEAROUT) {
>>> +		dev_warn(sec->dev, "Excessive flash update count detected\n");
>> If wear out is going to flood logs, move this to a warn once.
> There is no danger of flooding. The WEAROUT error will only be seen after 1000
> flash updates have occurred - an unlikely condition. It will also only occur
> once on an update, and only if they attempt to flash within 60 seconds of
> power-on or within 60 seconds of a previous flash.
>> Maybe make rsu_stat a function.
> Is there a reason to prefer a function in this case? Or should I change
> rsu_stat() to RSU_STAT() to make it more clear that it is a macro?

i was thinking a function could manage the warning messages.

If it will not flood, it is ok as-is.

Tom