linux-kernel - Re: [RFC PATCH v2] tracing: Remove duplicate `type` field from regmap `regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201124104854.430801a9@gandalf.local.home>
Date:   Tue, 24 Nov 2020 10:48:54 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Philippe Duplessis-Guindon <pduplessis@...icios.com>
Cc:     linux-trace-devel@...r.kernel.org, mathieu.desnoyers@...icios.com,
        linux-kernel@...r.kernel.org, broonie@...nel.org
Subject: Re: [RFC PATCH v2] tracing: Remove duplicate `type` field from
 regmap `regcache_sync` trace event

On Tue, 24 Nov 2020 08:57:30 -0500
Philippe Duplessis-Guindon <pduplessis@...icios.com> wrote:

> I have an error saying that `regcache_sync` has 2 fields named `type`
> while using libtraceevent.
> 
> Erase the `int field` type, which is not assigned. This field is
> introduced by mistake and this commit removes it.
> 
> Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event")
> 
> Signed-off-by: Philippe Duplessis-Guindon <pduplessis@...icios.com>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  drivers/base/regmap/trace.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h
> index d4066fa079ab..9abee14df9ee 100644
> --- a/drivers/base/regmap/trace.h
> +++ b/drivers/base/regmap/trace.h
> @@ -126,7 +126,6 @@ TRACE_EVENT(regcache_sync,
>  		__string(       name,           regmap_name(map)	)
>  		__string(	status,		status			)
>  		__string(	type,		type			)
> -		__field(	int,		type			)
>  	),
>  
>  	TP_fast_assign(