linux-kernel - RE: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card controllers use fixed indices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB6896C22F6B304F365C3BA626F8FB0@VI1PR04MB6896.eurprd04.prod.outlook.com>
Date:   Tue, 24 Nov 2020 07:41:01 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Vladimir Oltean <vladimir.oltean@....com>
CC:     Shawn Guo <shawnguo@...nel.org>, Leo Li <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ashish Kumar <ashish.kumar@....com>,
        Michael Walle <michael@...le.cc>
Subject: RE: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card
 controllers use fixed indices

Hi Vladimir,

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Friday, November 20, 2020 5:30 PM
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: Shawn Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; Rob
> Herring <robh+dt@...nel.org>; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; Adrian Hunter <adrian.hunter@...el.com>; Ulf
> Hansson <ulf.hansson@...aro.org>; linux-mmc@...r.kernel.org;
> linux-kernel@...r.kernel.org; Ashish Kumar <ashish.kumar@....com>;
> Michael Walle <michael@...le.cc>
> Subject: Re: [PATCH] arm64: dts: ls1028a: make the eMMC and SD card
> controllers use fixed indices
> 
> On Fri, Nov 20, 2020 at 02:04:02AM +0000, Y.b. Lu wrote:
> > Hi Vladimir,
> >
> > I have already upstreamed a patch for all affected layerscape boards.
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?
> h=imx/dt64&id=342ab37ecaf8c1b10dd3ca9a1271db29a6af0705
> >
> > Please check whether it works for you.
> 
> Thanks, one can tell that I haven't done my due diligence of checking
> Shawn's tree first. I'll cherry-pick that patch and carry on with my
> work.
> 
> However, the fact still remains that Michael has expressed his opinion
> regarding mmcblk0 vs mmcblk1. Do you think that we could make the
> aliases a per-board option instead of per-SoC? Consider that there might
> even be boards that only use SD card. It would be strange for the block
> device in that case to be called /dev/mmcblk1.

I don't think it's a problem in board dts to define board specific thing, like re-defining alias, and disabling any IP it not using.
Thanks.