linux-kernel - Re: [PATCH v2 3/3] Input: adp5589-keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8265d12-0269-a7ed-1f02-ee5679ee1db2@metafoo.de>
Date:   Tue, 24 Nov 2020 09:43:05 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     dmitry.torokhov@...il.com
Subject: Re: [PATCH v2 3/3] Input: adp5589-keys - add basic devicetree support

On 11/24/20 9:22 AM, Alexandru Ardelean wrote:
>   	error = devm_add_action_or_reset(&client->dev, adp5589_clear_config,
> @@ -1078,6 +1098,13 @@ static int __maybe_unused adp5589_resume(struct device *dev)
>   
>   static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, adp5589_resume);
>   
> +static const struct of_device_id adp5589_of_match[] = {
> +	{ .compatible = "adi,adp5585", .data = &adp5589_chip_info_tbl[ADP5585_01] },
> +	{ .compatible = "adi,adp5585-02", .data = &adp5589_chip_info_tbl[ADP5585_02] },
> +	{ .compatible = "adi,adp5589", .data = &adp5589_chip_info_tbl[ADP5589] },

I think we need to add these to 
Documentation/devicetree/bindings/trivial-devices.yaml