linux-kernel - Re: [PATCH] media: ov8856: Remove 3280x2464 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 10:43:43 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Dongchun Zhu <dongchun.zhu@...iatek.com>
Cc:     Robert Foss <robert.foss@...aro.org>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ben Kao <ben.kao@...el.com>, tfiga@...gle.com,
        shengnan.wang@...iatek.com
Subject: Re: [PATCH] media: ov8856: Remove 3280x2464 mode

Hi Dongchun,

On Tue, Nov 24, 2020 at 03:40:51PM +0800, Dongchun Zhu wrote:
> >  static const struct ov8856_mode supported_modes[] = {
> > -	{
> > -		.width = 3280,
> > -		.height = 2464,
> > -		.hts = 1928,
> > -		.vts_def = 2488,
> > -		.vts_min = 2488,
> > -		.reg_list = {
> > -			.num_of_regs = ARRAY_SIZE(mode_3280x2464_regs),
> > -			.regs = mode_3280x2464_regs,
> > -		},
> > -		.link_freq_index = OV8856_LINK_FREQ_720MBPS,
> > -	},
> 
> If 3280x2464 resolution is removed, bayer order needs to be updated in
> the meantime. From OV8856's datasheet, bayer order turns to be BGGR if
> sensor adopts full mode (3264x2448) or binning mode (1632x1224).

How is this related to the patch?

The next largest size is 16 by 16 less, so the Bayer order is the same. If
it's wrong currently (as it would appear to), it should be a separate
patch.

-- 
Sakari Ailus