linux-kernel - Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E34F9542-55FC-41EA-B757-9BBDCD6331C0@cisco.com>
Date:   Tue, 24 Nov 2020 01:14:40 +0000
From:   "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>
To:     "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>
CC:     "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG

Looks good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>

On 11/20/20, 5:38 PM, "Karan Tilak Kumar" <kartilak@...co.com> wrote:

    Replacing shost_printk with FNIC_MAIN_DBG so that
    these log messages are controlled by fnic_log_level
    flag in fnic_handle_link.

    Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
    Signed-off-by: Satish Kharat <satishkh@...co.com>
    ---
     drivers/scsi/fnic/fnic.h     | 2 +-
     drivers/scsi/fnic/fnic_fcs.c | 2 +-
     2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
    index 6dc8c916de31..7c5c911b2673 100644
    --- a/drivers/scsi/fnic/fnic.h
    +++ b/drivers/scsi/fnic/fnic.h
    @@ -39,7 +39,7 @@

     #define DRV_NAME		"fnic"
     #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
    -#define DRV_VERSION		"1.6.0.50"
    +#define DRV_VERSION		"1.6.0.51"
     #define PFX			DRV_NAME ": "
     #define DFX                     DRV_NAME "%d: "

    diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
    index 3337d6627baf..e0cee4dcb439 100644
    --- a/drivers/scsi/fnic/fnic_fcs.c
    +++ b/drivers/scsi/fnic/fnic_fcs.c
    @@ -75,7 +75,7 @@ void fnic_handle_link(struct work_struct *work)
     	atomic64_set(&fnic->fnic_stats.misc_stats.current_port_speed,
     			new_port_speed);
     	if (old_port_speed != new_port_speed)
    -		shost_printk(KERN_INFO, fnic->lport->host,
    +		FNIC_MAIN_DBG(KERN_INFO, fnic->lport->host,
     				"Current vnic speed set to :  %llu\n",
     				new_port_speed);

    -- 
    2.29.2