linux-kernel - Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58CCBA06-7F76-46C8-B0D5-194B5157E861@cisco.com>
Date:   Tue, 24 Nov 2020 01:10:45 +0000
From:   "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>
To:     "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>
CC:     "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG

Changes look good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>

On 11/20/20, 2:08 PM, "Karan Tilak Kumar" <kartilak@...co.com> wrote:

    Replacing shost_printk with FNIC_FCS_DBG so that
    these log messages are controlled by fnic_log_level
    flag in fnic_fip_handler_timer.

    Bumping up version number from 47 to 49 to
    maintain same level as internal version.

    Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
    Signed-off-by: Satish Kharat <satishkh@...co.com>
    ---
     drivers/scsi/fnic/fnic.h     | 2 +-
     drivers/scsi/fnic/fnic_fcs.c | 6 +++---
     2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
    index 477513dc23b7..ed00b6061e0c 100644
    --- a/drivers/scsi/fnic/fnic.h
    +++ b/drivers/scsi/fnic/fnic.h
    @@ -39,7 +39,7 @@

     #define DRV_NAME		"fnic"
     #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
    -#define DRV_VERSION		"1.6.0.47"
    +#define DRV_VERSION		"1.6.0.49"
     #define PFX			DRV_NAME ": "
     #define DFX                     DRV_NAME "%d: "

    diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
    index e3384afb7cbd..3fc3a7271dc1 100644
    --- a/drivers/scsi/fnic/fnic_fcs.c
    +++ b/drivers/scsi/fnic/fnic_fcs.c
    @@ -1349,7 +1349,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     	}

     	vlan = list_first_entry(&fnic->vlans, struct fcoe_vlan, list);
    -	shost_printk(KERN_DEBUG, fnic->lport->host,
    +	FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
     		  "fip_timer: vlan %d state %d sol_count %d\n",
     		  vlan->vid, vlan->state, vlan->sol_count);
     	switch (vlan->state) {
    @@ -1372,7 +1372,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     			 * no response on this vlan, remove  from the list.
     			 * Try the next vlan
     			 */
    -			shost_printk(KERN_INFO, fnic->lport->host,
    +			FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     				  "Dequeue this VLAN ID %d from list\n",
     				  vlan->vid);
     			list_del(&vlan->list);
    @@ -1382,7 +1382,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     				/* we exhausted all vlans, restart vlan disc */
     				spin_unlock_irqrestore(&fnic->vlans_lock,
     							flags);
    -				shost_printk(KERN_INFO, fnic->lport->host,
    +				FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     					  "fip_timer: vlan list empty, "
     					  "trigger vlan disc\n");
     				fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
    -- 
    2.29.2