linux-kernel - UAPI value collision: STATX_ATTR_MOUNT_ROOT vs STATX_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1927370.1606323014@warthog.procyon.org.uk>
Date:   Wed, 25 Nov 2020 16:50:14 +0000
From:   David Howells <dhowells@...hat.com>
To:     torvalds@...ux-foundation.org,
        Miklos Szeredi <mszeredi@...hat.com>,
        Ira Weiny <ira.weiny@...el.com>
cc:     dhowells@...hat.com, sandeen@...hat.com,
        linux-fsdevel@...r.kernel.org, linux-man@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: UAPI value collision: STATX_ATTR_MOUNT_ROOT vs STATX_ATTR_DAX

Hi Linus, Miklos, Ira,

It seems that two patches that got merged in the 5.8 merge window collided and
no one noticed until now:

80340fe3605c0 (Miklos Szeredi     2020-05-14 184) #define STATX_ATTR_MOUNT_ROOT		0x00002000 /* Root of a mount */
...
712b2698e4c02 (Ira Weiny          2020-04-30 186) #define STATX_ATTR_DAX			0x00002000 /* [I] File is DAX */

The question is, what do we do about it?  Renumber one or both of the
constants?

David