linux-kernel - Re: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b9e1500-f520-24a8-548e-d4952dab028c@huawei.com>
Date:   Thu, 26 Nov 2020 08:49:30 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "ACPI Devel Maling List" <linux-acpi@...r.kernel.org>,
        Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public

On 25/11/2020 17:43, Rafael J. Wysocki wrote:
> On Wed, Nov 25, 2020 at 6:25 PM John Garry<john.garry@...wei.com>  wrote:
>> To allow the platform device to "put" an irq, make the function to reset
>> an ACPI companion device irq resource public.
>>
>> Signed-off-by: John Garry<john.garry@...wei.com>
> I'd rather move it to kernel/resource.c as it is not ACPI-specific and
> its only connection to ACPI is that it is used in the ACPI resources
> management code.
> 

Hi Rafael,

That's ok, but we could also just put in include/linux/ioport.h as a 
static inline as it’s so small. Not so important, I guess.

And I'm not sure how this part could be merged, so maybe I can do as 2x 
patches now - 1. add resource.c function 2. remove ACPI duplicate. - so 
we have the option to merge ACPI part later if it makes things easier.

Thanks,
John