linux-kernel - Re: [PATCH] x86/irq: Lower unhandled irq error severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ea40c3e8-0be1-4783-ba1e-86c96cf8e4af@www.fastmail.com>
Date:   Fri, 27 Nov 2020 10:03:50 +0200
From:   Laurențiu Nicola <lnicola@...d.ro>
To:     "Thomas Gleixner" <tglx@...utronix.de>
Cc:     mingo@...hat.com, bp@...en8.de, x86@...nel.org, trivial@...nel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/irq: Lower unhandled irq error severity

Hello,

On Fri, Nov 27, 2020, at 02:12, Thomas Gleixner wrote:
> On Thu, Nov 26 2020 at 09:47, Laurențiu Nicola wrote:
> > These messages are described as warnings in the MSI code.
> 
> Where and what has MSI to do with these messages?

There's a comment referring to it as a warning, but an error seemed a more appropriate severity:

     * If the vector is unused, then it is marked so it won't
     * trigger the 'No irq handler for vector' warning in
     * common_interrupt().

> > Spotted because they break quiet boot on a Ryzen 5000 CPU.
> 
> They don't break the boot.
> 
> The machine boots fine, but having interrupts raised on a vector which
> is unused is really bad.

That's right, sorry. It still boots, but it's no longer "quiet", that's what I meant.

> Can you please provide the actual message from dmesg?

Sure:

[    0.316902] __common_interrupt: 1.55 No irq handler for vector
[    0.316902] __common_interrupt: 2.55 No irq handler for vector
[    0.316902] __common_interrupt: 3.55 No irq handler for vector
[    0.316902] __common_interrupt: 4.55 No irq handler for vector
[    0.316902] __common_interrupt: 5.55 No irq handler for vector
[    0.316902] __common_interrupt: 6.55 No irq handler for vector
[    0.316902] __common_interrupt: 7.55 No irq handler for vector
[    0.316902] __common_interrupt: 8.55 No irq handler for vector
[    0.316902] __common_interrupt: 9.55 No irq handler for vector
[    0.316902] __common_interrupt: 10.55 No irq handler for vector

These only show up during boot (and not e.g. when a disabling and enabling again a CPU).

Laurențiu