linux-kernel - Re: [PATCH] media: vb2: always set buffer cache sync hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8Eq4V++hRsKuYSF@jagdpanzerIV.localdomain>
Date:   Sat, 28 Nov 2020 01:35:45 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH] media: vb2: always set buffer cache sync hints

On (20/11/27 15:56), Hans Verkuil wrote:
> Yes.
> 
> BTW, wouldn't it be sufficient to change this code to:
> 
> 	if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) {
> 		vb->need_cache_sync_on_prepare = 1;
> 		vb->need_cache_sync_on_finish = 1;
> 	}

I think it would be sufficient.

	-ss