linux-kernel - Re: [PATCH] media: vb2: always set buffer cache sync hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAFQd5D7V8hbdZv_VxAUHUBsbknJsWMaU=h=5j19Z-J8FL27FQ@mail.gmail.com>
Date:   Sat, 28 Nov 2020 01:50:12 +0900
From:   Tomasz Figa <tfiga@...omium.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Hans Verkuil <hverkuil@...all.nl>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH] media: vb2: always set buffer cache sync hints

On Sat, Nov 28, 2020 at 1:35 AM Sergey Senozhatsky
<sergey.senozhatsky@...il.com> wrote:
>
> On (20/11/27 15:56), Hans Verkuil wrote:
> > Yes.
> >
> > BTW, wouldn't it be sufficient to change this code to:
> >
> >       if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) {
> >               vb->need_cache_sync_on_prepare = 1;
> >               vb->need_cache_sync_on_finish = 1;
> >       }
>
> I think it would be sufficient.

Does it matter at this point if allow_cache_hints is set or not?

Best regards,
Tomasz