linux-kernel - Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 14:10:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     trix@...hat.com, apw@...onical.com, nickhu@...estech.com,
        green.hu@...il.com, deanbo422@...il.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

On Fri, 2020-11-27 at 13:43 -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> From
> RFC MAINTAINERS tag for cleanup robot
> https://lkml.org/lkml/2020/11/21/190

I think this should be RFC.
It looks as as if it's only for subsystems through A

> The prefix used by subsystems in their commit log is arbitrary.
> To elimitate the time and effort to manually find a reasonable
> prefix, store the preferred prefix in the MAINTAINERS file.
> 
> Populate with reasonable prefixes using this algorithm.
> What did the maintainers use in their commits?
> If there were no maintainers commits then what did everyone
> else use in their commits.

The algorithm used to produce these prefixes should also be published.

> The results were manually reviewed and about 25% were rejected.

Because this isn't necessarily the best option.

I think an exception mechanism would be better than a specific
mechanism added to various entries.

>  # check MAINTAINERS entries for the right ordering too
> -			my $preferred_order = 'MRLSWQBCPTFXNK';
> +			my $preferred_order = 'MRLSWQBCPTFXNKD';
>  			if ($rawline =~ /^\+[A-Z]:/ &&
>  			    $prevrawline =~ /^[\+ ][A-Z]:/) {
>  				$rawline =~ /^\+([A-Z]):\s*(.*)/;

I'd prefer to keep the file and keyword list last.