linux-kernel - Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nBYycRrBFVQE-D8TfsLwFf+xrL=jcRN1cULG=3cexRDg@mail.gmail.com>
Date:   Fri, 27 Nov 2020 23:43:03 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     trix@...hat.com
Cc:     Robo Bot <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        nickhu@...estech.com, green.hu@...il.com, deanbo422@...il.com,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

On Fri, Nov 27, 2020 at 10:51 PM <trix@...hat.com> wrote:
>
> From
> RFC MAINTAINERS tag for cleanup robot
> https://lkml.org/lkml/2020/11/21/190

Please use lore.kernel.org for links.

> The prefix used by subsystems in their commit log is arbitrary.
> To elimitate the time and effort to manually find a reasonable

Typo in "eliminate".

> prefix, store the preferred prefix in the MAINTAINERS file.
>
> Populate with reasonable prefixes using this algorithm.
> What did the maintainers use in their commits?
> If there were no maintainers commits then what did everyone
> else use in their commits.

Why is this in the form of a question? I am not sure I understand --
is it rhetorical?

> The results were manually reviewed and about 25% were rejected.

What do you mean by rejected?

> Add 'D' tag to checkpatch.pl
>
> Use 'D' tag by adding --subsystem_commit_prefix option
> get_maintainer.pl

This looks also out of place, as if it was squashed from other
commits. I would suggest trying to reword the message in prose,
explaining the rationale and why it was done like this.

>  AUXILIARY DISPLAY DRIVERS

Missing entry for auxdisplay.

Cheers,
Miguel