linux-kernel - Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a48dbc8-59cc-5fff-e9ea-e68ffb9e698a@redhat.com>
Date:   Sat, 28 Nov 2020 08:30:41 -0800
From:   Tom Rix <trix@...hat.com>
To:     Joe Perches <joe@...ches.com>, apw@...onical.com,
        nickhu@...estech.com, green.hu@...il.com, deanbo422@...il.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix


On 11/28/20 8:00 AM, Joe Perches wrote:
> On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
>> On 11/27/20 2:10 PM, Joe Perches wrote:
> []
>>> I think an exception mechanism would be better than a specific
>>> mechanism added to various entries.
>> Can you give an example of what you mean ?
> Inherit the parent prefix then add the basename(dirname) as a default.
>
> For instance, changes to any subsystem of drivers/staging starts as
> "staging: " and with "$basename(path): " appended.

Ah, this is quite a bit different.

As far as I can tell there is no default.

MAINTAINERS would only have the exceptions, obviously needing drivers/foo to be 'foo:'

Without the full prefix, the user would be need to use get_maintainer.pl to figure it out.

Are the ""'s in the D value necessary ?

> So the MAINTAINERS entry for staging could be:
>
> STAGING SUBSYSTEM
> M:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> L:	devel@...verdev.osuosl.org
> S:	Supported
> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> D:	"staging: "
> F:	drivers/staging/
>
> Any specified D: use would override the generic form.
>
> And generic ARM changes could use the same mechanism with:
>
> ARM PORT
> M:	Russell King <linux@...linux.org.uk>
> L:	linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> S:	Odd Fixes
> W:	http://www.armlinux.org.uk/
> T:	git git://git.armlinux.org.uk/~rmk/linux-arm.git
> D:	"ARM: "
> F:	arch/arm/
> X:	arch/arm/boot/dts/
>
> And media likewise:
>
> MEDIA INPUT INFRASTRUCTURE (V4L/DVB)
> M:	Mauro Carvalho Chehab <mchehab@...nel.org>
> L:	linux-media@...r.kernel.org
> S:	Maintained
> W:	https://linuxtv.org
> Q:	http://patchwork.kernel.org/project/linux-media/list/
> T:	git git://linuxtv.org/media_tree.git
> D:	"media: "
> F:	Documentation/admin-guide/media/
> F:	Documentation/devicetree/bindings/media/
> F:	Documentation/driver-api/media/
> F:	Documentation/userspace-api/media/
> F:	drivers/media/
> F:	drivers/staging/media/
> F:	include/linux/platform_data/media/
> F:	include/media/
> F:	include/uapi/linux/dvb/
> F:	include/uapi/linux/ivtv*
> F:	include/uapi/linux/media.h
> F:	include/uapi/linux/meye.h
> F:	include/uapi/linux/uvcvideo.h
> F:	include/uapi/linux/v4l2-*
> F:	include/uapi/linux/videodev2.h
>
> etc...
>
>>>>  # check MAINTAINERS entries for the right ordering too
>>>> -			my $preferred_order = 'MRLSWQBCPTFXNK';
>>>> +			my $preferred_order = 'MRLSWQBCPTFXNKD';
>>>>  			if ($rawline =~ /^\+[A-Z]:/ &&
>>>>  			    $prevrawline =~ /^[\+ ][A-Z]:/) {
>>>>  				$rawline =~ /^\+([A-Z]):\s*(.*)/;
>>> I'd prefer to keep the file and keyword list last.
>>>
>> So change to
>>
>> my $preferred_order = 'MRLSWQBCPTDFXNK'; 
>>
>> ?
> Right.  And update the preferred_order in scripts/parse-maintainers.pl too.
>
>
>