linux-kernel - Re: [RESEND PATCH 1/2] iio:core: Introduce unlocked version of iio_map_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201128135435.33e9f6ee@archlinux>
Date:   Sat, 28 Nov 2020 13:54:35 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     andy.shevchenko@...il.com, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 1/2] iio:core: Introduce unlocked version of
 iio_map_array_unregister()

On Sat, 28 Nov 2020 14:44:18 +0100
Lino Sanfilippo <LinoSanfilippo@....de> wrote:

> Introduce an unlocked version of iio_map_array_unregister(). This function
> can help to unwind in case of error while the iio_map_list_lock mutex is
> held.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
Hi.

The mailing list is having issues today and as I use b4 to pull patches
from lore.kernel.org I can't easily pick this up.

I had as you've probably guessed forgotten about this one.
A few notes to make it harder for people to do that in future.
1. Don't send patch series (or new versions of older patches) in reply
   to an existing thread.   They get lost and difficult to pull out.
   b4 can't automatically figure out which patches to pull from that
   original thread for example.
2. Always version number whole series with same number, even if some patches
   are new.   So this should be v3.

Anyhow, I'll pick up this resend once the mailing list recovers or I get
annoyed enough to do it the old fashioned manual way.

Thanks,

Jonathan

> ---
>  drivers/iio/inkern.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index ede99e0..39c1d63 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -24,6 +24,21 @@ struct iio_map_internal {
>  static LIST_HEAD(iio_map_list);
>  static DEFINE_MUTEX(iio_map_list_lock);
>  
> +static int iio_map_array_unregister_locked(struct iio_dev *indio_dev)
> +{
> +	int ret = -ENODEV;
> +	struct iio_map_internal *mapi, *next;
> +
> +	list_for_each_entry_safe(mapi, next, &iio_map_list, l) {
> +		if (indio_dev == mapi->indio_dev) {
> +			list_del(&mapi->l);
> +			kfree(mapi);
> +			ret = 0;
> +		}
> +	}
> +	return ret;
> +}
> +
>  int iio_map_array_register(struct iio_dev *indio_dev, struct iio_map *maps)
>  {
>  	int i = 0, ret = 0;
> @@ -57,18 +72,12 @@ EXPORT_SYMBOL_GPL(iio_map_array_register);
>   */
>  int iio_map_array_unregister(struct iio_dev *indio_dev)
>  {
> -	int ret = -ENODEV;
> -	struct iio_map_internal *mapi, *next;
> +	int ret;
>  
>  	mutex_lock(&iio_map_list_lock);
> -	list_for_each_entry_safe(mapi, next, &iio_map_list, l) {
> -		if (indio_dev == mapi->indio_dev) {
> -			list_del(&mapi->l);
> -			kfree(mapi);
> -			ret = 0;
> -		}
> -	}
> +	ret = iio_map_array_unregister_locked(indio_dev);
>  	mutex_unlock(&iio_map_list_lock);
> +
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(iio_map_array_unregister);