linux-kernel - Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5d4c16b-74d7-403f-5f1c-8a1e8cbe4efb@intel.com>
Date:   Mon, 30 Nov 2020 09:48:56 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Huang Ying <ying.huang@...el.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Rafael Aquini <aquini@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...hat.com>, Mel Gorman <mgorman@...e.de>,
        Rik van Riel <riel@...hat.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>,
        David Rientjes <rientjes@...gle.com>, linux-api@...r.kernel.org
Subject: Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add
 mode flag MPOL_F_NUMA_BALANCING

On 11/25/20 9:32 PM, Huang Ying wrote:
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -113,6 +113,11 @@ A nonempty
>  .I nodemask
>  specifies node IDs that are relative to the set of
>  node IDs allowed by the process's current cpuset.
> +.TP
> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> +Enable the Linux kernel NUMA balancing for the task if it is supported
> +by kernel.  If the flag isn't supported by Linux kernel, return -1 and
> +errno is set to EINVAL.

The one thing I learned about manpage CodingStyle is that new sentences
go on new lines.  I think this needs to be:

.TP
.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
Enable the Linux kernel NUMA balancing for the task if it is supported
by kernel.
If the flag isn't supported by Linux kernel, return -1 and errno is set
to EINVAL.