lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 01 Dec 2020 08:27:43 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>,
        "Matthew Wilcox \(Oracle\)" <willy@...radead.org>,
        Rafael Aquini <aquini@...hat.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...hat.com>, "Mel Gorman" <mgorman@...e.de>,
        Rik van Riel <riel@...hat.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>,
        David Rientjes <rientjes@...gle.com>,
        <linux-api@...r.kernel.org>
Subject: Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Dave Hansen <dave.hansen@...el.com> writes:

> On 11/25/20 9:32 PM, Huang Ying wrote:
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,11 @@ A nonempty
>>  .I nodemask
>>  specifies node IDs that are relative to the set of
>>  node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +Enable the Linux kernel NUMA balancing for the task if it is supported
>> +by kernel.  If the flag isn't supported by Linux kernel, return -1 and
>> +errno is set to EINVAL.
>
> The one thing I learned about manpage CodingStyle is that new sentences
> go on new lines.  I think this needs to be:
>
> .TP
> .BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> Enable the Linux kernel NUMA balancing for the task if it is supported
> by kernel.
> If the flag isn't supported by Linux kernel, return -1 and errno is set
> to EINVAL.

Thanks a lot for your information!  I will revise this in the next version.

Best Regards,
Huang, Ying

Powered by blists - more mailing lists