linux-kernel - Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABJPP5C0eN5kC8-jB0Bes438GxWbwnNyYeN5a+6uym5MgyuBPw@mail.gmail.com>
Date:   Mon, 30 Nov 2020 23:56:59 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Peilin Ye <yepeilin.cs@...il.com>
Subject: Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe

On Mon, Nov 30, 2020 at 11:31 PM Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2020-11-30 at 23:02 +0530, Dwaipayan Ray wrote:
> > Sorry I think i explained wrong. For words like "doesn't", it still
> > has the same problem.
>
> I think you explained it wrong when you didn't mention this is
> _only_ a problem when using --codespell.
>
Sorry for that.
> Likely it'd be better to use "(?:^|\s)($misspellings)(?=\s|$)"
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7dc094445d83..b1783f02f745 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3106,7 +3106,7 @@ sub process {
>  # Check for various typo / spelling mistakes
>                 if (defined($misspellings) &&
>                     ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
> -                       while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) {
> +                       while ($rawline =~ /(?:^|\s)($misspellings)(?=\s|$)/gi) {
>                                 my $typo = $1;
>                                 my $typo_fix = $spelling_fix{lc($typo)};
>                                 $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
>
> $ cat t_spell.c
> // SPDX-License-Identifier: GPL-2.0-only
> void foo(void)
> {
>         //misspelled doesn' doesn't arne't word
> }
>
> $ ./scripts/checkpatch.pl -f --strict t_spell.c --codespell --codespellfile /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt
> CHECK: 'doesn'' may be misspelled - perhaps 'doesn't'?
> #4: FILE: t_spell.c:4:
> +       //misspelled doesn' doesn't arne't word
>

Thanks, this does resolve the original problem, but again the following
line throws 0 warnings:

"zeebra" ther, yourr.

Any punctuation separators are ignored :(

 (?:^|\s)($misspellings)(?=[\s\.\,\:\;\"\?\!]|$)

Would this be acceptable rather? But again this doesn't
handle [therr] or (therr).

Thank you,
Dwaipayan.