linux-kernel - Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddfde921e75f36cab2cd924d45dfbd11e07c6768.camel@perches.com>
Date:   Mon, 30 Nov 2020 11:37:30 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Peilin Ye <yepeilin.cs@...il.com>
Subject: Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with
 apostrophe

On Mon, 2020-11-30 at 23:56 +0530, Dwaipayan Ray wrote:
> Thanks, this does resolve the original problem, but again the following
> line throws 0 warnings:
> 
> "zeebra" ther, yourr.
> 
> Any punctuation separators are ignored :(
> 
>  (?:^|\s)($misspellings)(?=[\s\.\,\:\;\"\?\!]|$)
> 
> Would this be acceptable rather? But again this doesn't
> handle [therr] or (therr).

No idea.
What does codespell use for its regex?
Maybe that should be used.

Maybe all the added lines should be collected and
codespell should be called on those lines instead.

Try other options and check if the overall cpu/wall clock use is reduced.

Adding codespell's dictionary was kind of a 'nice to have' option and
it's not likely that it matters a lot if it's perfect or not.

My presumption is that it's not frequently used, but hey, who knows.