linux-kernel - Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202011301455.Dm3dgVlU-lkp@intel.com>
Date:   Mon, 30 Nov 2020 14:05:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Christoph Hellwig <hch@....de>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Namjae Jeon <linkinjeon@...nel.org>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on
 non-posix-acl build

Hi Sergey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hch-configfs/for-next]
[also build test WARNING on linux/master linus/master v5.10-rc6 next-20201127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/posix_acl-h-define-missing-ACL-functions-on-non-posix-acl-build/20201130-095018
base:   git://git.infradead.org/users/hch/configfs.git for-next
config: s390-randconfig-r005-20201130 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project dfcf1acf13226be0f599a7ab6b395b66dc9545d6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install s390 cross compiling tool for clang build
        # apt-get install binutils-s390x-linux-gnu
        # https://github.com/0day-ci/linux/commit/377ebc564d08d21a4bc83fecc7f1238e342823d1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sergey-Senozhatsky/posix_acl-h-define-missing-ACL-functions-on-non-posix-acl-build/20201130-095018
        git checkout 377ebc564d08d21a4bc83fecc7f1238e342823d1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from fs/overlayfs/super.c:16:
   In file included from include/linux/posix_acl_xattr.h:15:
   include/linux/posix_acl.h:121:19: error: static declaration of 'set_posix_acl' follows non-static declaration
   static inline int set_posix_acl(struct inode *inode, int type,
                     ^
   include/linux/posix_acl.h:72:12: note: previous declaration is here
   extern int set_posix_acl(struct inode *, int, struct posix_acl *);
              ^
>> include/linux/posix_acl.h:127:55: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
   static inline int posix_acl_update_mode(struct inode *, umode_t *,
                                                         ^
   include/linux/posix_acl.h:127:66: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
   static inline int posix_acl_update_mode(struct inode *, umode_t *,
                                                                    ^
   include/linux/posix_acl.h:128:25: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
                                           struct posix_acl **)
                                                              ^
   3 warnings and 1 error generated.

vim +127 include/linux/posix_acl.h

   126	
 > 127	static inline int posix_acl_update_mode(struct inode *, umode_t *,
   128						struct posix_acl **)
   129	{
   130		return 0;
   131	}
   132	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (28305 bytes)